Handle key deposit for Shelley transactions #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is.. tricky, because the deposit is sort of implicit but, because of the dual support with Jörmungandr, we have to treat it as a fee. So, there's a bit of weird logic / work-around when creating the actual transaction.
- using 28-byte hash length for key hashes - adding certificate witnesses to the estimation
KtorZ
force-pushed
the
KtorZ/1799/key-deposit-shelley-transactions
branch
from
a19bc0e
to
3564517
Compare
KtorZ
commented
Jun 26, 2020
| @@ -31,7 +31,7 @@ protocolParams: | |||
| extraEntropy: | |||
| tag: NeutralNonce | |||
| maxBlockHeaderSize: 217569 | |||
| keyDeposit: 0 | |||
| keyDeposit: 100 | |||
There was a problem hiding this comment.
This little one made pretty much all integration tests to fail, as they should.
KtorZ
commented
Jun 26, 2020
| , if null certs | ||
| then Set.empty | ||
| else Set.singleton (dummyWitness dummyTxIn) | ||
| ) |
There was a problem hiding this comment.
Had to revise the size estimation too because it was wrong :/ ...
a) The hash length were still 32 bytes
b) Certificate witnesses weren't counted
Turned out that, until I introduced the deposit amount, b) and a) were both balancing each other (we were allocating too much fee because of the wrong hash sizes, and it was coping with the lack of witness for the certificate 🤷 )
KtorZ
force-pushed
the
KtorZ/1799/key-deposit-shelley-transactions
branch
from
3564517
to
0784356
Compare
|
bors try |
KtorZ
added
the
RESOLVING ISSUE
tryBuild failed |
|
bors try |
tryBuild failed |
|
bors retry |
tryBuild succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1799
Overview
8085f82
📍 add a non-null key deposit to genesis, and account for it for launching pools
8240a15
📍 account for key deposit when registering a stake key
This is.. tricky, because the deposit is sort of implicit but, because of the dual support with Jörmungandr, we have to treat it as a fee. So, there's a bit of weird logic / work-around when creating the actual transaction.
285d027
📍 fix fee calculation for Shelley
adding certificate witnesses to the estimation
0495b96
📍 give deposit back when de-registing a stake key
a19bc0e
📍 adjust test scenarios according to recent API changes
Comments
Not 100% ideal, but works without too much added complexity.