keep track of the last applied checkpoint in the chain follower #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we avoid discarding rollbacks when they occur beyond the initial step.
KtorZ
added
the
RESOLVING ISSUE
Anviking
reviewed
Jun 26, 2020
| @@ -361,27 +361,27 @@ follow nl tr cps yield header = | |||
| where | |||
| eT = T.pack (show e) | |||
|
|
|||
| step :: Int -> Cursor target -> IO FollowExit | |||
| step delay cursor = runExceptT (nextBlocks nl cursor) >>= \case | |||
| step :: Int -> [BlockHeader] -> Cursor target -> IO FollowExit | |||
There was a problem hiding this comment.
I think [BlockHeader] is a very confusing type here. Can we not have BlockHeader and call it say followerTip?
There was a problem hiding this comment.
Gets a bit weird with the last cps0 not necessarily being apart of the chain though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#1796
Overview
📍 keep track of the last applied checkpoint in the chain follower
So that we avoid discarding rollbacks when they occur beyond the initial step.
Comments