Add 'Initial' message-decoder with config parameters #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anviking
commented
May 15, 2019
| \5e05f5f8e53b87e7ea452f000000000000000e" | ||
| genesisHeader | ||
|
|
||
| it "should decode a genesis block" $ do |
There was a problem hiding this comment.
should decode a genesis block header is now redundant, but I didn't mind the duplication since we would get more information from the test output without looking at the details. Happy to change though.
Anviking
commented
May 15, 2019
| -- Seconds elapsed since 1-Jan-1970 (unix time) | ||
| = Block0Date Word64 | ||
| | ConfigDiscrimination Discrimination | ||
| | ConsensusVersion Word16 -- ? |
There was a problem hiding this comment.
Types here are obviously not that polished
Anviking
commented
May 15, 2019
| -- 12 most-significant bits: tag | ||
| taglen <- getWord16be | ||
| let tag = taglen `shift` (-6) | ||
| let len = fromIntegral $ taglen .&. (63) -- 0b111111 |
There was a problem hiding this comment.
Had this bit-wise logic separate at first, but
TagLenwould be completely uninteresting to the rest of the code- Testing it indirectly through
getConfigParam . putConfigParamroundtrip should be fine…? 🤔 or we will miss potential edge-cases?
KtorZ
reviewed
May 16, 2019
| a -> fail $ "Invalid config param with tag " ++ show a | ||
|
|
||
| data Discrimination = Production | Test | ||
| deriving (Eq, Show) |
There was a problem hiding this comment.
That should basically match the Cardano.Wallet.Environment.Jormungandr. There's no more protocol magic with Jormungandr but instead, only two levels of discrimination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#218
Overview
Initialmessage,ConfigParamand some child typesComments