Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leaks of ≈21 more wallets in integration tests #2857

Merged
merged 2 commits into from
Aug 29, 2021

Conversation

Anviking
Copy link
Member

  • Replace 3 manual calls to Link.postWallets with the ResourceT postByronWallet
  • Also make createWalletFromPublicKeyViaCLI run in ResourceT

Comments

  • 21 wallets is a pretty significant number, so will be good to fix. Although the leaks were at the end of the tests, which lessens the impact.
  • There seem to be some concurrency related leaks.

Before second fix

  • --match "WALLET" -j 1 ->18 leaks, all at the end

After fixes

  • --match "WALLET" -j 1, no leaks
  • --match "WALLET" -j 8, 10 leaks (3 BUSY, 6 others)
SQLITE_BUSY in logs:
ica.14828b804a1ebe804caddd1abb5d314d2be0a62a.sqlite
ica.25341683360a040721f587d069b95762b302f608.sqlite
rnd.5fc0960622bc4d3a5d366a0920dfd9b5ef578ced.sqlite

rnd.81273c47add77e98b3993e01cab8b2a836cd48b7.sqlite
she.95cff5e68f07b759c72d4da4f1aa96e0b101bba2.sqlite
she.a99218ce4bbc77f05617d642c0595246621b67b6.sqlite

Remaining DBs:
ica.14828b804a1ebe804caddd1abb5d314d2be0a62a.sqlite
ica.25341683360a040721f587d069b95762b302f608.sqlite
rnd.5fc0960622bc4d3a5d366a0920dfd9b5ef578ced.sqlite

ica.ed49f6e7723fa2c15575c147566981beab6aba3e.sqlite
rnd.693940686b48985ab6ec8035a56575e0473e96de.sqlite
rnd.81273c47add77e98b3993e01cab8b2a836cd48b7.sqlite
sha.9316fc445533f9e58becf0d367d3a9404585ea86.sqlite
she.3464b427c15341dab8aaf6d89c8f79e5f24f9eae.sqlite
she.a0bd7c6accac92d54fb667bf32bcba4db4cd552f.sqlite
stake-pools.sqlite

Issue Number

ADP-1090

@Anviking Anviking force-pushed the anviking/ADP-1090/more-wallet-leaks branch from a321eeb to b077f8e Compare August 27, 2021 19:13
@Anviking Anviking self-assigned this Aug 27, 2021
@rvl
Copy link
Contributor

rvl commented Aug 29, 2021

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 29, 2021

Build succeeded:

@iohk-bors iohk-bors bot merged commit e43dec2 into master Aug 29, 2021
@iohk-bors iohk-bors bot deleted the anviking/ADP-1090/more-wallet-leaks branch August 29, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants