Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indexes to certain SQLite table columns #293

Merged
merged 2 commits into from
May 21, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented May 21, 2019

Relates to issue #154.

Overview

Some of the searching and sorting that the DBLayer does will be greatly improved by creation of SQL indexes. By default, only primary key columns get indexes.

This PR adds a sprinkling of CREATE INDEX as a start.

What we really need to do is set up a benchmark of the DBLayer to ensure that performance is reasonable. I.e. no accidentally quadratic behaviour.

@paweljakubas paweljakubas merged commit 8c5d985 into rvl/154/sqlite-checkpoints May 21, 2019
@iohk-bors iohk-bors bot deleted the rvl/154/sqlite-indexes branch May 21, 2019 08:40
@KtorZ KtorZ removed this from the SQLite implementation for the DB Layer milestone Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants