Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI port argument bug. #407

Merged
merged 6 commits into from
Jun 13, 2019
Merged

Fix CLI port argument bug. #407

merged 6 commits into from
Jun 13, 2019

Commits on Jun 13, 2019

  1. introduce PortOption datatype and tweak logic in api server

    @paweljakubas @KtorZ
    paweljakubas authored and KtorZ committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    52402b4 View commit details
    Browse the repository at this point in the history

  2. force launcher to use --random-port for wallet 

    Rationale here is to simplify a bit the requirement and busy work with the launcher that
we're going to remove / merge into the wallet cli soon.
    @KtorZ
    KtorZ committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    b2b4433 View commit details
    Browse the repository at this point in the history

  3. fix docopt port & random-port declaration

    @KtorZ
    KtorZ committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    2c4ea5b View commit details
    Browse the repository at this point in the history

  4. Review tests for --port & fixes how the port get passed through tests 

    There's a bit of Haskell lens magic here. But that's for a greater good.
    @KtorZ
    KtorZ committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    15aee06 View commit details
    Browse the repository at this point in the history

  5. add more tests about the --port to cover every command of the CLI

    @KtorZ
    KtorZ committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    0aa67a7 View commit details
    Browse the repository at this point in the history

  6. re-generate nix packages

    @KtorZ
    KtorZ committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    264c31f View commit details
    Browse the repository at this point in the history