Encrypt metadata spec and types #4176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unisay
reviewed
Oct 24, 2023
paweljakubas
force-pushed
the
paweljakubas/adp-322/encrypt-metadata
branch
from
f1fa5af
to
c2a7360
Compare
paweljakubas
requested review from
HeinrichApfelmus,
Anviking,
Unisay,
jonathanknowles,
paolino and
david-a-clark
paweljakubas
force-pushed
the
paweljakubas/adp-322/encrypt-metadata
branch
3 times, most recently
from
33489e9
to
8ef1343
Compare
Unisay
reviewed
Nov 6, 2023
Unisay
reviewed
Nov 6, 2023
Unisay
reviewed
Nov 6, 2023
paweljakubas
force-pushed
the
paweljakubas/adp-322/encrypt-metadata
branch
2 times, most recently
from
c4b5cf1
to
bd2a689
Compare
paweljakubas
force-pushed
the
paweljakubas/adp-322/encrypt-metadata
branch
2 times, most recently
from
ad2601c
to
8b08f75
Compare
Unisay
reviewed
Nov 15, 2023
| ``` | ||
| { | ||
| ... | ||
| "metadata": "metadata encrypted" |
There was a problem hiding this comment.
If "encrypt_metadata" is an object for extensibility purposes (an object allows to specify an encryption algorithm that was chosen), would it also make sense to make the encrypted metadata an object carrying the information about selected encryption algorithm?
There was a problem hiding this comment.
when we support other encryption algos this is going to be a must. but for now I made sure encrypt_metadata object could be extended in non-intrusive way for future. When we add it then we will add "string" with algo details along encrypted bytes. We will easily be able to handle this in noninvasive way and be backward compatible. thanks for the remark!
Unisay
reviewed
Nov 15, 2023
Comment on lines
+79
to
+82
| { "1": "Hard times create strong men." | ||
| , "2": "Strong men create good times." | ||
| , "3": "Good times create weak men." | ||
| , "4": "And, weak men create hard times." |
Unisay
reviewed
Nov 15, 2023
| ... | ||
| } | ||
| ``` | ||
| as metadata values have 64-byte limit. In that case the encrypted metadata is encoded in the successive bytes. |
There was a problem hiding this comment.
So this makes it impossible to decrypt a single key without using the cardano-wallet?
There was a problem hiding this comment.
we need to append 64-byte chunks and then you can decrypt whole. And you can do it outside cardano-wallet if you comply with algos and passphrase symmetrizing algo
Unisay
reviewed
Nov 15, 2023
| -- Above is the way to get a compiler error when number of fields changes, | ||
| -- in order not to forget to update the pattern below: | ||
| case body of | ||
| ApiConstructTransactionData | ||
| { payments = Nothing | ||
| , withdrawal = Nothing | ||
| , metadata = Nothing | ||
| , encryptMetadata = Nothing |
Unisay
approved these changes
Nov 15, 2023
paweljakubas
force-pushed
the
paweljakubas/adp-322/encrypt-metadata
branch
from
8b08f75
to
c42044d
Compare
WilliamKingNoel-Bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
…llet points the work accomplished in this PR. Before you submit, don't forget to: CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Make sure the GitHub PR fields are correct: ✓ Set a good Title for your PR. ✓ Assign yourself to the PR. ✓ Assign one or more reviewer(s). ✓ Link to a Jira issue, and/or other GitHub issues or PRs. ✓ In the PR description delete any empty sections and all text commented in <!--, so that this text does not appear in merge commit messages. CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Don't waste reviewers' time: ✓ If it's a draft, select the Create Draft PR option. ✓ Self-review your changes to make sure nothing unexpected slipped through. CODE-OF-CONDUCT.md CONTRIBUTING.md LICENSE MAINTAINERS.md README.md cabal.project default.nix docker-compose.yml docs flake.lock flake.nix floskell.json fourmolu.yaml hie-direnv.yaml justfile lib nix prototypes reports scripts shell.nix specifications test touch.me.CI weeder.dhall Try to make your intent clear: ✓ Write a good Description that explains what this PR is meant to do. ✓ Jira will detect and link to this PR once created, but you can also link this PR in the description of the corresponding Jira ticket. ✓ Highlight what Testing you have done. ✓ Acknowledge any changes required to the Documentation. --> - [x] Adding spec and change swagger accordingly - [x] Add field `encrypt_metadata` to `ApiConstructTransactionPostData` - [x] Introduce ApiDecodeTransactionPostData` - [x] deal with all code adjustment - [x] adjust unit tests ### Issue Number ADP-322 Source commit: fd9eb91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encrypt_metadatatoApiConstructTransactionPostDataIssue Number
ADP-322