Always call applyBlock, even if block is empty #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rvl
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
OK, good. I guess the reason why we didn't catch the bug before is that, because of its location, this empty block filtering logic could only be tested with integration tests, which did not cover blockHeight. So you have done a good thing removing this code.
Depending on how long the http-bridge backend exists, maybe we can ignore that it produces EBBs.
Anviking
force-pushed
the
anviking/640/always-call-applyBlock
branch
from
b99ee8d
to
91c39f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#640
Overview
filter nonEmptyfor blocks inrestoreBlocks, such that all blocks from the networkLayer get passed toapplyBlocks. This should correct the block-height calculation (but it is currently untested / just played with a bit manually).Comments
cardano-wallet-http-bridge, because Epoch Boundary Blocks (EBBs) are no longer filtered outstack bench cardano-wallet-http-bridge:restore