Skip to content

Conversation

nemo83
Copy link
Contributor

@nemo83 nemo83 commented Oct 1, 2025

fixes: #24

@nemo83 nemo83 requested a review from matiwinnetou October 1, 2025 20:17
Copy link
Contributor

@matiwinnetou matiwinnetou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only small thing I would ask if we can exactly document this as comment why we are adding two lines. Yes I know we have git blame and a person can look up the ticket but it maybe easier to have it in the code, what do you think?

@nemo83
Copy link
Contributor Author

nemo83 commented Oct 2, 2025

The only small thing I would ask if we can exactly document this as comment why we are adding two lines. Yes I know we have git blame and a person can look up the ticket but it maybe easier to have it in the code, what do you think?

Comments get stale, code is law, will split each line into two:

  1. slot time
  2. end of slot time
    This will make things more explicit

@nemo83 nemo83 merged commit 01f5b43 into main Oct 2, 2025
2 checks passed
@nemo83 nemo83 deleted the fix/last-20-second-epoch-issue branch October 2, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong epoch resolution in last 20 seconds of epoch (after byron)
2 participants