feat(ui): I already have a wallet #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-fupp4ippt.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-c96rmfbwj.vercel.app |
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-22sv25323.vercel.app |
sdisalvo-crd
requested changes
Jun 14, 2024
Sotatek-DukeVu
force-pushed
the
feature/DTIS-898-already-have-a-wallet
branch
from
449ba17
to
1b96e36
Compare
Sotatek-DukeVu
force-pushed
the
feature/DTIS-898-already-have-a-wallet
branch
from
1b96e36
to
396157d
Compare
|
Vercel PR (merge commit) deploy URL: https://cf-identity-wallet-ckdkn7abf.vercel.app |
iFergal
reviewed
Jun 17, 2024
| @@ -6,8 +6,11 @@ import { | |||
| enum KeyStoreKeys { | |||
| APP_PASSCODE = "app-login-passcode", | |||
| APP_OP_PASSWORD = "app-operations-password", | |||
| PASSWORD_SKIPPED = "app-password-skip", | |||
There was a problem hiding this comment.
These are not meant to be going into the key store. This needs to be changed.
The key store is for secrets. There is a mechanism in the core for storing misc items like this called basic storage.
There was a problem hiding this comment.
@bao-sotatek can support here
sdisalvo-crd
added a commit
that referenced
this pull request
Jun 17, 2024
This reverts commit 48feccb.
iFergal
pushed a commit
that referenced
this pull request
Jun 17, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement recovery wallet flow when user click on
I already have a walletbutton.Checklist before requesting a review
Issue ticket number and link
Testing & Validation
Security
Code Review
Design Review
IOS
Screen.Recording.2024-06-14.at.14.10.56.mov
Android
Screen.Recording.2024-06-14.at.14.25.35.mov
Browser
Screen.Recording.2024-06-14.at.13.47.13.mov
Verify Seed Phrase Fail
Screen.Recording.2024-06-14.at.14.41.01.mov