Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Localization + Support for Russian #29

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Conversation

ftp27
Copy link
Contributor

@ftp27 ftp27 commented Oct 1, 2019

And also Russian localization :)

Copy link
Owner

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ftp27 this is looking great! Thank you!!

You just missed adding the locale to the genres API call as well

Repository owner deleted a comment from codecov-io Oct 1, 2019
@codecov-io
Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #29 into master will decrease coverage by 1.19%.
The diff coverage is 36.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #29     +/-   ##
=========================================
- Coverage   73.64%   72.45%   -1.2%     
=========================================
  Files          13       13             
  Lines         425      432      +7     
=========================================
  Hits          313      313             
- Misses        112      119      +7
Impacted Files Coverage Δ
...ovieDB/Controllers/MovieDetailViewController.swift 11.11% <0%> (-1.02%) ⬇️
...xMovieDB/Controllers/MovieListViewController.swift 89.58% <100%> (ø) ⬆️
ReduxMovieDB/ViewState/MovieDetailViewState.swift 100% <100%> (ø) ⬆️
ReduxMovieDB/API/TMDB.swift 68.75% <50%> (-2.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4a4a5...e1a443c. Read the comment docs.

@ftp27
Copy link
Contributor Author

ftp27 commented Oct 1, 2019

@cardoso Oh. Sorry. It's ok now

Copy link
Owner

@cardoso cardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉

@cardoso cardoso changed the title Resolved #15 Localization [NEW] Localization + Support for Russian Oct 1, 2019
@cardoso cardoso merged commit 2e94202 into cardoso:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants