Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use crates.io sparse index by default #1310

Closed
NobodyXu opened this issue Aug 23, 2023 · 0 comments · Fixed by #1314
Closed

Use crates.io sparse index by default #1310

NobodyXu opened this issue Aug 23, 2023 · 0 comments · Fixed by #1314

Comments

@NobodyXu
Copy link
Member

crates.io API is not meant to be used for finding and downloading crates metadata.

It's also rate limited to 1 request per second, while crates.io sparse index is designed for such activities.

Switching to crates.io sparse index would fix this and avoid hitting crates.io with unnecessary API calls and remove a huge amount of code in our codebase.
NobodyXu added a commit that referenced this issue Aug 23, 2023
@NobodyXu
binstalk-registry: Use crates.io sparse index by default
a0f526f 
Fixed #1310

Also add rename `fetch_crate_cratesio` => `fetch_crate_cratesio_api` and
put it behind a new feature `crates_io_api`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu added a commit that referenced this issue Aug 23, 2023
@NobodyXu
binstalk-registry: Use crates.io sparse index by default
499442f 
Fixed #1310

Also add rename `fetch_crate_cratesio` => `fetch_crate_cratesio_api` and
put it behind a new feature `crates_io_api`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this issue Aug 23, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 24, 2023
@NobodyXu
binstalk-registry: Use crates.io sparse index by default (#1314)
b9adaa0 
Fixed #1310

Also add rename `fetch_crate_cratesio` => `fetch_crate_cratesio_api` and
put it behind a new feature `crates_io_api`.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this issue Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

binstalk-registry: Use crates.io sparse index by default cargo-bins/cargo-binstall
1 participant
@NobodyXu