Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Fix handling of invalid UTF-8 characters in form input #1053

Closed
fauvel opened this issue Mar 5, 2014 · 8 comments · Fixed by #1057
Closed

Fix handling of invalid UTF-8 characters in form input #1053

fauvel opened this issue Mar 5, 2014 · 8 comments · Fixed by #1057
Assignees
Labels

Comments

@fauvel
Copy link
Contributor

fauvel commented Mar 5, 2014

Follow-up of #1051

@cm-jan your fix doesn't work in PHP 5.4 and 5.5

@cm-jan
Copy link
Contributor

cm-jan commented Mar 5, 2014

Could you provide more info on that? thanks

@fauvel
Copy link
Contributor Author

fauvel commented Mar 5, 2014

Have a look at the Travis builds of #1051 – the ? don't get stripped in PHP 5.4 and 5.5, so your tests are failing.

@cm-jan
Copy link
Contributor

cm-jan commented Mar 5, 2014

you're right, thanks, I haven't noticed that.

On 3/5/14, 12:53 PM, Sébastien Fauvel wrote:

Have a look at the Travis builds
https://travis-ci.org/cargomedia/CM/builds/20053144 of #1051
#1051 – the |?| don't get
stripped in PHP 5.4 and 5.5, so your tests are failing.


Reply to this email directly or view it on GitHub
#1053 (comment).

@fauvel
Copy link
Contributor Author

fauvel commented Mar 5, 2014

I've just noticed it because I had fixed all the tests in PHP 5.4 and 5.5 in #1046, then I've merged upstream and all the builds went red again... :(

@fauvel
Copy link
Contributor Author

fauvel commented Mar 5, 2014

@cm-jan could you consider this small task as having a high priority? The CI tests are now failing for all pull requests, that's quite annoying. Thank you!

@cm-jan
Copy link
Contributor

cm-jan commented Mar 5, 2014

I'm finishing this right now

On 3/5/14, 2:42 PM, Sébastien Fauvel wrote:

@cm-jan https://github.com/cm-jan could you consider this small task
as having a high priority? The CI tests are now failing for all pull
requests, that's quite annoying.


Reply to this email directly or view it on GitHub
#1053 (comment).

@fauvel
Copy link
Contributor Author

fauvel commented Mar 5, 2014

Ok, great!

@njam
Copy link
Member

njam commented Mar 5, 2014

Please revert fdefafc here as well (enabling php 5.5 for travis)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants