Trap SIGPIPE on Travis

[fauvel]

No description provided.

[njam]

• can we use SIGPIPE instead of 13 for readability?
• Do we need absolute path to php? Or could we use just php?
• Instead of empty trap do something like # this happens because of...?

[fauvel]

It looks like I'm still missing some elements to reproduce this green build...

[fauvel]

Interesting :)

[fauvel]

Find the difference: 26be461...70da096...

[fauvel]

I'm pretty sure now it is an issue with the PDO connection opened by the AWS SDK.

[njam]

Hmmm, why is the AWS SDK opening a PDO connection? We use the "s3" API only, I don't think it should (nor is configured) to open a database connection.

[fauvel]

I'm not absolutely sure, but gdb said we have a SEGPIPE on shutdown as a static class member variable is being freed and tries to close a PDO connection... My last suspect is CachePDO::$pdo, in vendor/amazonwebservices/aws-sdk-for-php/lib/cachecore/cachepdo.class.php. But it's not even static...

[njam]

Maybe try disabling the AWS-related tests and see whether it works?

[fauvel]

Yes, it does works without AWS-related tests.

But even CM_Action_AbstractTest::testNotify() triggers a Segfault in the end...

So maybe the problem rather comes from phpredis? CM_Action_Abstract::_track() instantiates a Redis object via CM_KissTracking::track(), CM_KissTracking::_getSet() and CM_SetAdapter_Redis::add(). And there we have a connection (using PDO internally?) that we're not closing explicitly. And it is being stored statically on CM_Redis_Client::getInstance(), which would explain the gdb backtrace.

[njam]

Hmm I don't think the redis extension uses PDO code.
Hmhmhm

[fauvel]

Is it just me, or is there a problem with the linking of Travis builds right now? I can see an indicator besides the commit ssh on GitHub as long as the build is running, but then it disappears...

[njam]

Mhhm had it before. Maybe make the PR mergeable, maybe it helps..?

[fauvel]

So it did pass at e08237e, with CM_KissTrackingTest disabled and all AWS-related tests enabled.

[njam]

So this aws sdk is actually long deprecated - maybe we should try upgrading to the new version?

[fauvel]

Closed in favor of #1046

[scrutinizer-notifier]

The inspection completed: No new issues