-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
- Happening on shutdown, we're losing the PDO connection while the code coverage is running - Should work fine now in PHP 5.4
|
It looks like I'm still missing some elements to reproduce this green build... |
Interesting :) |
- Fixed condition
- Fixed condition
- Disabled all tests
Find the difference: 26be461...70da096... |
I'm pretty sure now it is an issue with the PDO connection opened by the AWS SDK. |
Hmmm, why is the AWS SDK opening a PDO connection? We use the "s3" API only, I don't think it should (nor is configured) to open a database connection. |
I'm not absolutely sure, but |
Maybe try disabling the AWS-related tests and see whether it works? |
Yes, it does works without AWS-related tests. But even So maybe the problem rather comes from phpredis? |
Hmm I don't think the redis extension uses PDO code. |
Is it just me, or is there a problem with the linking of Travis builds right now? I can see an indicator besides the commit ssh on GitHub as long as the build is running, but then it disappears... |
Mhhm had it before. Maybe make the PR mergeable, maybe it helps..? |
Conflicts: tests/library/CM/Action/AbstractTest.php tests/library/CM/KissTrackingTest.php
So this aws sdk is actually long deprecated - maybe we should try upgrading to the new version? |
Closed in favor of #1046 |
The inspection completed: No new issues |
No description provided.