Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Remove scrutinizer? #1078

Merged
merged 1 commit into from
Mar 14, 2014
Merged

Conversation

mariansollmann
Copy link
Contributor

Because:

  • Nobody looks at the results
  • Sometimes the results are still weird / don't make sense
  • Slows down the build

@mariansollmann wdyt?
@tomaszdurka fyi

Added here: https://github.com/cargomedia/CM/pull/1000/files

@mariansollmann
Copy link
Contributor

@njam I lock into the scrutinizer results, but maybe its better to remove this.

@njam
Copy link
Member Author

njam commented Mar 13, 2014

And is it useful for you?

BTW do you understand the following?
#1037 -> Changes: 1 added function, without docu and tests
Scrutinizer -> "Test Coverage has increased to 68% (+5%)."

@njam
Copy link
Member Author

njam commented Mar 13, 2014

CodeClimate for PHP coming: https://codeclimate.com/php

@mariansollmann
Copy link
Contributor

@njam sometimes its helpful sometimes irritating. Lets remove it and wait for https://codeclimate.com/php

@njam
Copy link
Member Author

njam commented Mar 14, 2014

agree, can you take over?

@mariansollmann
Copy link
Contributor

@dlondero please review.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@dlondero
Copy link
Contributor

@mariansollmann Looks good! Merge at will.

mariansollmann pushed a commit that referenced this pull request Mar 14, 2014
@mariansollmann mariansollmann merged commit c2d65e6 into cargomedia:master Mar 14, 2014
@mariansollmann mariansollmann deleted the issue-1078 branch May 9, 2014 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants