This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zazabe
commented
May 11, 2017
•
edited
Loading
edited
- Extract site / language / version from Url path parts
- Use AppUrl in CM_Request
- Map CM_Response with AppUrl
Conflicts: library/CM/Frontend/Render.php
@{c7e8ab9c-90bf-4796-bb88-9aa7c8150044,Reto Kaiser} here we are... this is the challenging PR i told you, about https://youtrack.cargomedia.ch/issue/FB-115... |
replace CM_Request::getPathPart($index) by CM_Request::getUrl()->getPathSegmentAt($index)
Used by log formatter, because getQuery() could raise an exception (eg. CM_Http_Request_Post)
There are some problems with One idea would be to cut the dependencies at |
Idea:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.