Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client rework and optimizations #119

Merged
merged 3 commits into from
May 18, 2022

Conversation

sdg9
Copy link
Collaborator

@sdg9 sdg9 commented May 18, 2022

  • Use client more consistently where available
  • Prefer functions over classes where viable so that we don't have to deal with the behavior or this
  • Enhance client socket ability to reconnect if disconnected

Closes #117
Closes #111
Closes #108

@nx-cloud
Copy link

nx-cloud bot commented May 18, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5f965df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@sdg9 sdg9 merged commit 22d0f69 into caribou-crew:main May 18, 2022
@sdg9 sdg9 deleted the sdg9/clientCleanupv2 branch May 18, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant