feat: update record screen styling #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3e58f24. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
sdg9
reviewed
Jun 1, 2022
| let icon = <ChangeCircle />; | ||
|
|
||
| switch (status) { | ||
| case 200: |
There was a problem hiding this comment.
@NSwanson1 I would have done something like x >= 200 && x <= 299 is green, and so on for 4xx and 5xx.
Also while not implemented with UI yet we may want a color for requests in flight (right now items only show up when response is completed), first implementation I had those as yellow but maybe gray or something is fine.
If you really want a switch you could do something funky like switch on Math.floor(status/100) and use case 2, 4, and 5
sdg9
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web styling changes to recording screen
Closes #112