Add the start of recording/intercepting support #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nx g @nrwl/node:lib utils-logger --publishable --importPath @caribou-crew/mezzo-utils-logger
Currently it is a REST based instead of socket based way to capture and it doesn't monkeypatch
Consider moving most of the server side logic here to better distinguish between core-client and core-server (hosting vs making REST or socket requests) Core could then potentially be shared between both
sdg9
requested review from
NSwanson1 and
Gonzalo8642
and removed request for
NSwanson1
Gonzalo8642
approved these changes
May 7, 2022
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "name": "@caribou-crew/mezzo-core-client", | |||
| "version": "0.0.1" | |||
There was a problem hiding this comment.
Not a huge issue, but react, react-dom and react-test-renderer all have the same version number. I can only assume this is so they can make sure everything is compatible with each other. Might be a good idea to do the same if we think we'll spend time writing migration/compatibility guides. I don't think we'll need to actively maintain both of these at the same time. So maybe it's not as important
There was a problem hiding this comment.
Let's chat more im not ready to publish this package to npm yet anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #94
High level
Under the hood mezzo uses sockets to communicate from RN <--> Mezzo server <--> Mezzo admin web.
Large concepts and even chunks of code were used from Reactotron (MIT license) in the RN integration layer as it is exactly what they do to capture network traffic.
It's a hefty PR and in many ways still a work in progress but if anyone wants to run with UI I don't anticipate any serious need to change the interfaces or data structures so we can always get this in while I continue polishing.