Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle seeing current priv again after trying to escalate auth #234

Merged
merged 1 commit into from
May 14, 2022

Conversation

carlmontanari
Copy link
Owner

dont timeout when devices are not ready to escalate auth. cropped up in scrapligo/boxen when connecting to device that just fired up -- sending "enable" caused the device to say something like "cant do that yet, not ready" and kicked back to the exec prompt. scrapligo died at that point as it was looking for either the password prompt or the privilege exec prompt. this fixes that to also accept seeing the exec (or w/e the current prompt is) prompt one more time. this is fine because before moving on we validate the current prompt/priv level is what we want (before breaking out of the escalate auth loop).

@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #234 (8ab6cbd) into develop (036ea92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #234   +/-   ##
========================================
  Coverage    90.49%   90.49%           
========================================
  Files           59       59           
  Lines         3449     3449           
========================================
  Hits          3121     3121           
  Misses         328      328           
Impacted Files Coverage Δ
scrapli/driver/network/async_driver.py 96.93% <ø> (ø)
scrapli/driver/network/sync_driver.py 96.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 036ea92...8ab6cbd. Read the comment docs.

@carlmontanari carlmontanari merged commit a976db3 into develop May 14, 2022
@carlmontanari carlmontanari deleted the priv-escalate-accept-current-prompt branch May 14, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant