hidapi instead of libusb (windows support) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WinkelCode, would you mind testing this on the platforms you have access to? |
carlossless
force-pushed
the
hidapi-win-fix
branch
from
a81a511
to
1a31aad
Compare
|
🎉 I didn't test writing, but reading seems to work on Windows now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using libusb for raw HID communication doesn't seem to be suitable for Windows. The approach would work fine on macOS and Linux, but it was never been tested on Windows.
Changes here replace direct libusb usage with hidapi. Linux would still use the hidapi libusb backend, since the hidraw backend doesn't seem to recognize the ISP device as a regular HID device.
Addresses #8
Testing