Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better schema generation for filters #985

Closed
wants to merge 1 commit into from
Closed

better schema generation for filters #985

wants to merge 1 commit into from

Conversation

yihuang
Copy link

@yihuang yihuang commented Oct 18, 2018

No description provided.

@yihuang yihuang mentioned this pull request Oct 18, 2018
Closed
@deanpienaar deanpienaar mentioned this pull request Oct 25, 2018
Closed
carltongibson
carltongibson reviewed Dec 17, 2018
View reviewed changes
Copy link
Owner

@carltongibson carltongibson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This is a marginal improvement on the the schema generation front, so would be good to have for now. (Core API will eventually be removed from DRF.)

@carltongibson
Copy link
Owner

Ah. Tests. Rebase and re-run needed.

@carltongibson
Copy link
Owner

So rebasing and looking at the test failures, the change in filterset.py can't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @carltongibson