forked from aws/amazon-ecs-agent
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An 295 update fork push #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add windows gMSA integration logic Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
Add credentialspec task resource to state manager and fix deadlock issue
This commit contains the following bug fixes: 1. Issue with chmod on windows 2. Authorization exception when one process holds the handle for the file and other process tries to move or rename it 3. File naming issues on windows (Fixed issue of using task id as part of fileName) 4. Fix issue to avoid creating `credentialspec` files with `.json` extension
Fix credentialspec cleanup issue for gMSA windows support.
Add functional test for credentialspec local file option
Implement GMSA functional tests for S3/SSM
Merge feature/gMSA into dev
Bump |
bellpeterm
approved these changes
Dec 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will be glad to see it pushed everywhere with a version tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.34.0-papyrus+1
1.34.0