use the correct number of values to unpack (detector distance missing) #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSimonne
approved these changes
Jan 11, 2022
Yes, this is the issue when interpolating with xrayutilities (#220 ), I forgot to update that part of the code (which is not yet covered by unit tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The number of values to unpack from the call to beamline.Beamline.process_position was not correct (detector distance was not taken into account). The code for all beamlines has been corrected.
Fixes #220
Type of change
Test Configuration:
Tested on ID01 dataset with interpolation using xrayutilities.
Checklist:
doitand all tasks have passed