Refactor: group loading methods in a new abstract class Loader #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
February 13, 2022 20:59
Inheritance is used to deal with beamline_specific data loading.
Implementation of ID01BLISS
|
Clement's branch merged, need to implement some unit tests before merging this PR into the main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All methods related to data loading are now in the same class. Methods have been moved from the Diffractometer and Beamline classes to Loader. This is an abstract base class, so when there is a need to implement a new loading schema (e.g. for BLISS at ID01), one will only need to implement a new child class with the required methods.
A side-effect is that there is no more need for Diffractometer child classes, the beamline-specific details can be stored in a named tuple.
Type of change
How has this been tested?
The pre-processing and post-processing scripts for the example dataset run as expected.
Checklist:
doitand all tasks have passed