Bug: apply correctly binning to the pixel size used in the transformation matrices #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carnisj
changed the title
DSimonne
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Use the binned detector pixel size to calculate the transformation matrices.
One needs to use detector.pixelsize_x (_y) instead of the unbinned pixel size. This bug was introduced when moving the properties pixelsize_x (_y) from the Setup class to the Detector class.
I added another modes.h5 with preprocessing=[1,2,2].
I will use it later to implement a high-level test about the interpolation (e.g. using the number of support voxels in the interpolated result)
Fixes #219
Type of change
How has this been tested?
Interpolation of the example dataset in an orthonormal frame works correctly now with preprocessing_binning = (1,2,2).
Checklist:
doitand all tasks have passed