Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set command line parameters as optional #231

Merged
merged 8 commits into from
Feb 13, 2022
Merged

Set command line parameters as optional #231

merged 8 commits into from
Feb 13, 2022

Conversation

carnisj
Copy link
Owner

@carnisj carnisj commented Feb 8, 2022

Pull Request Template

Description

Now the command line parameters do not need to be provided. ConfigParser can be instantiated providing only the path to the config file

Fixes #230

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

The error with the weird string value of flip_reconstruction in the GUI is solved.

Checklist:

  • I have added corresponding unit tests
  • I have run doit and all tasks have passed

@carnisj carnisj marked this pull request as ready for review February 9, 2022 06:54
@carnisj carnisj requested a review from DSimonne February 9, 2022 06:54
Copy link
Collaborator

@DSimonne DSimonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with gwaihir, by not loading the command line args anymore =)

@carnisj carnisj merged commit 5245f70 into main Feb 13, 2022
@carnisj carnisj deleted the bug_parsing branch February 13, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Arguments not parsed properly when using the GUI
2 participants