-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement __repr__
such that eval(repr(instance)) is an instance
#237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be reused by `create_repr` to convert numpy arrays to a list
Hi @DSimonne could you have a look at this PR? I would like to merge it before to avoid conflicts |
I can try to have a look this week |
DSimonne
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement correctly the
__repr__
method in classes such that eval(repr(instance)) is itself an instance of the class.utilities.create_repr
andutilities.format_repr
__repr__
methodsbeamline
from Setup had to be renamedbeamline_name
, because it was overlapping with the attribute beamline which is a Beamline instanceFixes #207
Tests pass, also checked with the example dataset.
Type of change
Checklist:
doit
and all tasks have passed