Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESRF ID27 beamline #273

Merged
merged 67 commits into from
Jun 21, 2022
Merged

Add support for ESRF ID27 beamline #273

merged 67 commits into from
Jun 21, 2022

Conversation

carnisj
Copy link
Owner

@carnisj carnisj commented Jun 19, 2022

Add support for high-energy BCDI at ID27. The detector is in a SAXS-like geometry, not on a goniometer. The interpolation (taking into account the curvature of Ewald sphere) is currently done with griddata and is very slow. The interpolation using GPU code will be implemented in a separate PR, since this one is already large enough.

Processing for experiments with such a detector are now supported via a separate module bcdi.preprocessing.process_scan_cdi.

The implementation of diffractometers is modified to take into account this so-called SAXS geometry. Parameters corresponding to the detector stages are used instead of detector goniometer angles.

Fixes #264

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Test with a dataset from ID27.

Checklist:

  • I have made corresponding changes to the documentation
  • I have added corresponding unit tests
  • I have run doit and all tasks have passed

@carnisj carnisj marked this pull request as draft June 19, 2022 18:16
carnisj and others added 29 commits June 19, 2022 20:21
@carnisj carnisj marked this pull request as ready for review June 20, 2022 19:17
@carnisj carnisj requested review from clatlan and DSimonne June 20, 2022 19:18
Copy link
Collaborator

@DSimonne DSimonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Overall it looks good, I did not see any particular problem.
For that amount of files I think the best is to test it with data!

I will also have to change a few things in Gwaihir since there are new parameters and scripts

@DSimonne
Copy link
Collaborator

Would be nice if Clément checks it as well before merging

@clatlan
Copy link
Collaborator

clatlan commented Jun 21, 2022

I was having a look as well. It seems fine to me. As @DSimonne suggests the easiest way to proceed is to analyse multiple ID27 scans, maybe @sjleake has some more.

@clatlan
Copy link
Collaborator

clatlan commented Jun 21, 2022

Or @mirichard-S !

@clatlan clatlan merged commit 252dd2d into main Jun 21, 2022
@DSimonne DSimonne deleted the id27 branch June 21, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add support for ESRF ID27
3 participants