-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ESRF ID27 beamline #273
Conversation
…oniometer and BeamlineSaxs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Overall it looks good, I did not see any particular problem.
For that amount of files I think the best is to test it with data!
I will also have to change a few things in Gwaihir since there are new parameters and scripts
Would be nice if Clément checks it as well before merging |
Or @mirichard-S ! |
Add support for high-energy BCDI at ID27. The detector is in a SAXS-like geometry, not on a goniometer. The interpolation (taking into account the curvature of Ewald sphere) is currently done with griddata and is very slow. The interpolation using GPU code will be implemented in a separate PR, since this one is already large enough.
Processing for experiments with such a detector are now supported via a separate module
bcdi.preprocessing.process_scan_cdi
.The implementation of diffractometers is modified to take into account this so-called SAXS geometry. Parameters corresponding to the detector stages are used instead of detector goniometer angles.
Fixes #264
Type of change
How has this been tested?
Test with a dataset from ID27.
Checklist:
doit
and all tasks have passed