use centering_method in the bragg peak location calculation
#278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DSimonne
approved these changes
Jul 18, 2022
The Bragg peak position can be determined by other methods than the COM (e.g. MAX, MAXCOM)
…or direct and reciprocal space
several methods are used to find the bragg peak
… different methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the Bragg peak position for the three methods "max", "com" and "max_com" and plot the results to compare their efficiency. The type of
centering_methodis changed todictin order to provide different methods for direct and reciprocal space (e.g.{"direct_space": "max_com", "reciprocal_space": "max"}).Fixes #276
The signature of the methods
find_braggandshow_rocking_curvehas changed.Checklist:
doitand all tasks have passed