Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot to check qualitatively the centering method #291

Merged
merged 6 commits into from
Aug 14, 2022
Merged

Conversation

carnisj
Copy link
Owner

@carnisj carnisj commented Jul 30, 2022

In the presence of hotpixels, some centering methods are not performing well (typically, those based on the center of mass). A plot of the peak position determined by each of the methods 'max', 'com' and 'max_com' is now saved automatically to help checking the validity of the parameter setting for centering_method.

Fix #288

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have made corresponding changes to the documentation
  • I have run doit and all tasks have passed

peaks

@carnisj carnisj requested review from clatlan and DSimonne July 30, 2022 19:10
@carnisj carnisj self-assigned this Jul 30, 2022
@carnisj carnisj added the enhancement New feature or request label Jul 30, 2022
@carnisj carnisj merged commit 78e1966 into main Aug 14, 2022
@carnisj carnisj deleted the centering branch August 14, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Centering method
2 participants