-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KeyType #20
Comments
Affected Files
|
|
It turns out that EncounterGroup and PatientGroup rely on KeyType for some core functionality. So, rather than remove KeyType completely, I moved it up to carnival.clinical.util and left it in use by PatientGroup and EncounterGroup. I had already removed it from FrequencyMatcher.... which I suspect is a class that will be rethought anyways. |
augustearth
added a commit
that referenced
this issue
Sep 25, 2020
augustearth
added a commit
that referenced
this issue
Sep 25, 2020
augustearth
added a commit
that referenced
this issue
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
KeyType was important for Carnival v0 when there were complex data operations that consumed and produced data tables. With the introduction of the graph in Carnival v1, these operations are done in the graph. KeyType is no longer central and should be removed for simplicity's sake.
There is overlap here with secondaryIdFieldMap of GenericDataTable and MappedDataTable. Like KeyType, the secondaryIdFieldMap was important for data table operations. Because secondaryIdFieldMap depends on KeyType, it is not possible to remove KeyType without removing secondaryIdFieldMap.
The text was updated successfully, but these errors were encountered: