-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Remove Travis CI, and tox #705
Conversation
3218cd5
to
8e104aa
Compare
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #705 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 113 113
Lines 14532 14532
Branches 2959 2959
=========================================
Hits 14532 14532
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
It has been replaced with GHA.
It is not needed on GHA, and is apparently not used in sandbox mode (no references in `bin/checkdone.sh` and `bin/test.sh`).
It was masked because `tox` satisfied the dependency transitively.
6a951a2
to
80b85a0
Compare
I saw your reference that we shouldn't be even using codecov anymore as well. Great investigation on your part. I"m okay with merging this now or if you think we should drop codecov here too and add it to the github actions too? I seem to think this comment may be dejavu and already addressed though. You've been a machine with all the amazing work you've done over the past few weeks. Is that the case here? |
Are you referring to the
Code coverage reports are being uploaded using the Codecov Action already, as recommended. apprise/.github/workflows/tests.yml Lines 121 to 128 in 7c993fb
|
Amazing work! As always! - Merged |
Dear Chris,
#702 will add the CI setup and GHA, and it looks like you like it. As a followup, this patch will consecutively remove Travis CI, and tox.
With kind regards,
Andreas.