Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove Travis CI, and tox #705

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

amotl
Copy link
Collaborator

@amotl amotl commented Oct 16, 2022

Dear Chris,

#702 will add the CI setup and GHA, and it looks like you like it. As a followup, this patch will consecutively remove Travis CI, and tox.

With kind regards,
Andreas.

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7c993fb) compared to base (7c993fb).
Patch has no changes to coverable lines.

❗ Current head 7c993fb differs from pull request most recent head 80b85a0. Consider uploading reports for the commit 80b85a0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #705   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          113       113           
  Lines        14532     14532           
  Branches      2959      2959           
=========================================
  Hits         14532     14532           
Flag Coverage Δ
unittests 99.99% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

It has been replaced with GHA.
It is not needed on GHA, and is apparently not used in sandbox mode
(no references in `bin/checkdone.sh` and `bin/test.sh`).
It was masked because `tox` satisfied the dependency transitively.
@amotl amotl changed the title [STACK] CI: Remove Travis CI, and tox CI: Remove Travis CI, and tox Oct 18, 2022
@amotl amotl marked this pull request as ready for review October 18, 2022 11:28
@caronc
Copy link
Owner

caronc commented Oct 18, 2022

I saw your reference that we shouldn't be even using codecov anymore as well. Great investigation on your part.

I"m okay with merging this now or if you think we should drop codecov here too and add it to the github actions too? I seem to think this comment may be dejavu and already addressed though. You've been a machine with all the amazing work you've done over the past few weeks. Is that the case here?

@amotl
Copy link
Collaborator Author

amotl commented Oct 18, 2022

I saw your reference that we shouldn't be even using codecov anymore as well. Great investigation on your part.

Are you referring to the codecov-python program here? Yeah, it is getting deprecated, see codecov/codecov-python#198 (comment).

I"m okay with merging this now or if you think we should drop codecov here too and add it to the github actions too?

Code coverage reports are being uploaded using the Codecov Action already, as recommended.

- name: Upload coverage data
uses: codecov/codecov-action@v3
with:
files: ./coverage.xml
flags: unittests
env_vars: OS,PYTHON,BARE
name: codecov-umbrella
fail_ci_if_error: false

@caronc
Copy link
Owner

caronc commented Oct 20, 2022

Amazing work! As always! - Merged

@caronc caronc merged commit eafa749 into caronc:master Oct 20, 2022
@caronc caronc deleted the amo/remove-travis-and-tox branch October 20, 2022 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants