Add optional customizable cancelBarButtonItem and doneBarButtonItem #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrenchen1223, can you review this pull request? |
bcylin
reviewed
Jul 18, 2017
| @@ -70,6 +70,10 @@ internal class CarousellImagePickerController: ImagePickerController { | |||
|
|
|||
| private struct CarousellTheme: ImagePickerConfigurable { | |||
|
|
|||
| let cancelBarButtonItem: UIBarButtonItem? = UIBarButtonItem(barButtonSystemItem: .stop, target: nil, action: nil) | |||
|
|
|||
| let doneBarButtonItem: UIBarButtonItem? = UIBarButtonItem(title: "Next", style: .plain, target: nil, action: nil) | |||
There was a problem hiding this comment.
Would it be better to use NSLocalizedString like imagePicker.button.camera? so we can later update the translation.
There was a problem hiding this comment.
Just noticed that it's for the example app. It should be alright. 😅
| var cancelBarButtonItem: UIBarButtonItem? { get } | ||
|
|
||
| /// A custom bar button item displayed on the right (or trailing) edge of the navigation bar when the receiver is the top navigation item. | ||
| var doneBarButtonItem: UIBarButtonItem? { get } |
jianyaoang
force-pushed
the
feature/custom-edit-done-barbutton
branch
from
4cb36a8
to
b7d16ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional UIBarButtonItems in ImagePickerConfigurable to customise appearance of cancelBarButtonItem and doneBarButtonItem.