Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Directories #34

Merged
merged 2 commits into from
Apr 4, 2019
Merged

Update Project Directories #34

merged 2 commits into from
Apr 4, 2019

Conversation

bcylin
Copy link
Collaborator

@bcylin bcylin commented Oct 7, 2018

Previously the project is using the default setup generated via pod lib create, which has a nested project layout:

.
├── Example
│   ├── Pickle.xcodeproj
│   └── Pods
│       └── Pods.xcodeproj
└── Pickle.xcodeproj -> Example/Pods/Pods.xcodeproj  // a symlink for Carthage support

It has a few problems so far:

  • xcodeporj and xcworkspace are not in the root directory. Uneasy to find at first glance and it also requires an additional flag when running pod install.
  • Pickle.framework is built via CocoaPods. It needs to rerun pod install after source files are changed during implementation.
  • Example/Pods/Pods.xcodeproj/project.pbxproj has large diffs whenever CocoaPods regenerates the project.

This pull request moves the project to a single xcodeporj in the root directory with three targets:

  • Pickle.framework
  • PickleExample.app with the framework as the target dependency
  • PickleUITests

It should be simpler and easier to manage than the nested directories.

@carouselljenkins
Copy link

@jianyaoang, can you review this pull request?

@carouselljenkins
Copy link

carouselljenkins commented Oct 7, 2018

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@bcylin bcylin requested a review from victorneo March 15, 2019 22:53
@bcylin bcylin requested review from daveluong and removed request for victorneo April 4, 2019 07:11
@daveluong
Copy link
Contributor

👍 I've experienced all these problems during development of this PR #39

@daveluong
Copy link
Contributor

I have tested and this works perfectly. Merging it now

@daveluong daveluong merged commit 1d79b69 into master Apr 4, 2019
@daveluong daveluong deleted the feature/single-project branch April 4, 2019 10:08
@bcylin bcylin mentioned this pull request Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants