Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe(r) mkdir and touch #37

Closed

Conversation

chrisosaurus
Copy link
Contributor

Attempting to address #33

I have defined a set of characters allowed within mkdir and touch, both will refuse any string which isn't made up entirely of those characters.

I have also changed boot.lisp to load builtins before core, so that core can use builtins in the implementation - I think this makes sense.

This was referenced Jul 9, 2016
@eriksvedang
Copy link
Collaborator

Cool, I'll merge this when I'm back at my computer tomorrow or Monday.

@ghost
Copy link

ghost commented Jul 9, 2016

What about spaces and special characters (as pointed out by @lieuwex)?

@chrisosaurus
Copy link
Contributor Author

chrisosaurus commented Jul 10, 2016

@shyguy as mentioned on #33 I was planning to add those later, happy to drop in favour of #43 if it is still safe.

@chrisosaurus
Copy link
Contributor Author

I'm breaking out the other parts of this commit in preparation for this being closed.
#44 - changing boot ordering (builtins before core)
#45 - string contains

refactoring shell-safe? to use do notation

updating shell-safe-chars to include `.` for relative paths
@chrisosaurus
Copy link
Contributor Author

rebased and squashed down.

depends on #44 and #45 landing first.

@chrisosaurus
Copy link
Contributor Author

Closing in favour of #43

@chrisosaurus chrisosaurus deleted the safe-mkdir-and-touch branch July 13, 2016 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants