Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Scheduling jobs" -- remark about environment variables is incorrect #48

Closed
reid-a opened this issue Sep 18, 2018 · 3 comments
Closed

Comments

@reid-a
Copy link
Contributor

reid-a commented Sep 18, 2018

In the "Scheduling jobs" episode, under the "other types of jobs" subsection, there is a remark that environment variables are not available for interactive jobs launched via "srun". On the two SLURM clusters available to me, this is not true for either of them -- doing "srun" followed by "env" shows that in the shell session, the "SLURM_*" environment variables are set, and the explicitly-mentioned SLURM_CPUS_PER_TASK variable is set if the "-c" flag was provided to "srun".

This might be configurable, and vary from one installation to another?

@psteinb
Copy link
Contributor

psteinb commented Sep 19, 2018

Can you pinpoint me to the specific position in the episode, please?

@reid-a
Copy link
Contributor Author

reid-a commented Sep 19, 2018

It's towards the end of the episode. In the "Other types of jobs" sub-heading, there's a paragraph that begins "srun takes the same options as sbatch" -- the parenthetical remark at the end of that paragraph is the wording I'm referring to.

@reid-a
Copy link
Contributor Author

reid-a commented Sep 28, 2018

I just ran a few more tests, and even in the case where "bash" is not run (e.g. the "echo" example in the lesson), the SLURM environment variables appear to be set.
I'm sufficiently confident that I'm sending a pull request with revised wording.

psteinb pushed a commit that referenced this issue Oct 1, 2018
Reworded the text about SLURM environment variables.  Fixes issue #48.
@reid-a reid-a closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants