Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix Node.js warnings linked to GitHub actions #1

Merged

Conversation

jhlegarreta
Copy link

Fix Node.js warnings linked to GitHub actions: use Node.js 20.x, and bump versions actions/checkout@v4, actions/setup-node@v4, upload-artifact@v4, and download-artifact@v4

Fixes:

Update Workflow
Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3, carpentries/create-pull-request@main.
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

raised for example in:
https://github.com/carpentries-incubator/SDC-BIDS-fMRI/actions/runs/9753104282

Please delete this line and the text below before submitting your contribution.


Thanks for contributing!

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.


Fix `Node.js` warnings linked to GitHub actions: use `Node.js` 20.x, and
bump versions `actions/checkout@v4`, `actions/setup-node@v4`,
`upload-artifact@v4`, and `download-artifact@v4`

Fixes:
```
Update Workflow
Node.js 16 actions are deprecated.
Please update the following actions to use Node.js 20:
actions/checkout@v3, carpentries/create-pull-request@main.
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

raised for example in:
https://github.com/carpentries-incubator/SDC-BIDS-fMRI/actions/runs/9753104282
@jhlegarreta jhlegarreta force-pushed the FixGitHubActionsNodejsWarning branch from 2902702 to 9596861 Compare July 2, 2024 14:11
@jhlegarreta jhlegarreta changed the title ENH: Fix Node.js warnings linked to GitHub actions ENH: Fix Node.js warnings linked to GitHub actions Jul 2, 2024
@ErinBecker
Copy link

Thank you for these fixes @jhlegarreta. Sorry this took a while to get to, but these look good to me!

@ErinBecker ErinBecker merged commit b09d6e8 into carpentries:main Aug 23, 2024
@jhlegarreta jhlegarreta deleted the FixGitHubActionsNodejsWarning branch August 23, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants