Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct to all in one page for search #131

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Direct to all in one page for search #131

merged 9 commits into from
Apr 9, 2024

Conversation

ErinBecker
Copy link
Contributor

@ErinBecker ErinBecker commented Mar 22, 2024

The goal of this PR (in combination with SANDPAPER PR LINK) is to:

  • Remove the inactive search box icon from lesson pages (this PR)
  • Replace with a button pointing towards the lesson's all in one page (this PR)
  • Make search button title translatable (https://github.com/ErinBecker/sandpaper/tree/translate-aio)
  • Add a banner to the top of the all in one page directing folks to use ctl-f for search (SANDPAPER PR LINK)

The screenshot below shows the replacement of the search box icon with a button pointing towards the lesson's all in one page:
Screenshot 2024-03-22 at 3 13 34 PM

Note to self and @froggleston - if we end up merging this, please squash and merge, there's a lot of commits where I was experimenting.

Fixes carpentries/workbench#8

Make "Search in this lesson's "all in one" page" translatable.
@ErinBecker
Copy link
Contributor Author

With https://github.com/ErinBecker/sandpaper/tree/translate-aio, allows for translation of the new "Search the All In One page" button, however, have discovered a problem - need to not render this button on workshop overview pages, as they don't have an All In One page.

Note to self, look at the code linked below to figure out how to make addition of page elements dependent on whether a lesson is an overview page:

@ErinBecker
Copy link
Contributor Author

This now adds the search all in one button to the top of any lesson that is not a workshop overview (Thanks @froggleston!), and the search button is translatable through the .po files.

@froggleston froggleston merged commit 4ded22f into carpentries:main Apr 9, 2024
1 check passed
@froggleston
Copy link
Contributor

LGTM! Awesome work! 🚀

@ErinBecker ErinBecker deleted the aio-search branch April 9, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search functiontionality is disabled (text box not selectable)
2 participants