-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct to all in one page for search #131
Conversation
Make "Search in this lesson's "all in one" page" translatable.
With https://github.com/ErinBecker/sandpaper/tree/translate-aio, allows for translation of the new "Search the All In One page" button, however, have discovered a problem - need to not render this button on workshop overview pages, as they don't have an All In One page. Note to self, look at the code linked below to figure out how to make addition of page elements dependent on whether a lesson is an overview page: |
This now adds the search all in one button to the top of any lesson that is not a workshop overview (Thanks @froggleston!), and the search button is translatable through the .po files. |
LGTM! Awesome work! 🚀 |
The goal of this PR (in combination with SANDPAPER PR LINK) is to:
The screenshot below shows the replacement of the search box icon with a button pointing towards the lesson's all in one page:
Note to self and @froggleston - if we end up merging this, please squash and merge, there's a lot of commits where I was experimenting.
Fixes carpentries/workbench#8