Fix 0.10 stable build #1847
Fix 0.10 stable build #1847
Conversation
This is more convenient for development as we switched to PG in the master branch.
Otherwise, Bundler fails resolving a version using Ruby 1.9.3.
|
Appears to be some issue installing |
|
@thomasfedb the build fails for older Rubies (1.8 and 1.9.2) due to the gems dependencie https://travis-ci.org/carrierwaveuploader/carrierwave/jobs/105075508#L189 |
|
Given that Rails 3.2 supports Ruby 1.8.7, and also that we're fixing this retrospectively, I feel that we should continue to test 0.10.x against 1.8.7, although we could drop support in 0.11.x if that is released. |
|
Given that For example, in 3.2.22.1, the version of |
| s.add_development_dependency "fog", ">= 1.3.1" | ||
| s.add_development_dependency "fog", "~> 1.20.0" | ||
| s.add_development_dependency "unf" | ||
| s.add_development_dependency "net-ssh", "~> 2.9.0" |
There was a problem hiding this comment.
To fix test for ruby 1.8.7, we should specify some gem versions:
s.add_development_dependency "mini_magick", "< 4"
s.add_development_dependency "i18n", "< 0.7"
s.add_development_dependency "mime-types", "< 2"
s.add_development_dependency "sprockets", "< 3"
s.add_development_dependency "net-ssh", "< 2.10"
s.add_development_dependency "rack-cache", "< 1.3"
Specs fails for Rails 4.1.0 but not Rails 4.1.0.rc1 It seems to be a Rails issue fixed at rails/rails@595f7b0 This commit fixes it by requiring Rails when necessary to ensure it's loaded and `Rails.env` is defined.
mehlah
force-pushed
the
fix-0.10-stable-build
branch
from
debd85e
to
d85a083
Compare
With Container based CI, public projects can cache the bundle. This make the build 🚤 https://docs.travis-ci.com/user/caching/#Enabling-Bundler-caching
|
Annd it's 💚 ! Thanks @mtsmfm for your hints. |
|
🎉 |
|
Looks great! |
Fix dependency and config issues in CI build
This PR should fix the build for 0.10-stable branch.
It's a first step I hope towards releasing an intermediate version with some backports, before the 1.0 release ✌️.
@thomasfedb I'd be happy to discuss and share some thoughts on the release plan you guys wants to go with.
Fix #1822