Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade deps #215

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade deps #215

wants to merge 3 commits into from

Conversation

calebeby
Copy link
Contributor

No description provided.

@jescalan
Copy link
Contributor

why are all the returns removed?

@calebeby
Copy link
Contributor Author

calebeby commented Aug 25, 2017 •
edited
Loading

https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#boom-breaking-changes

Resolution method is overspecified. Specify a callback or return a Promise; not both.

I was going through removing done in a bunch of places, but then it gave me an error, so I just removed the returns instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebeby @jescalan