Remove WormMap and WormSet. #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is entirely up to you, @bruno-roustant . If you think there is no clear advantage to using WormMap then I think it makes sense to get rid of them to decrease library size. I did a quick lookup of how many times people may be using it [1] but I don't think it's used that frequently, so perhaps we should go ahead and remove. [1] https://github.com/search?q=WormMap%20path%3A*.java&type=code |
|
If you decide to go ahead, then perhaps add an entry to changes.txt? |
|
Thanks for searching usages. I agree it is not used much except in benchmarks. |
|
Yep, looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the latest improvements to HashMap, in practice WormMap is not useful compared to HashMap. For example, in Lucene, WormMap and HashMap were compared and HashMap was chosen.
If I had some improvements to bring, I would work on HashMap.
So, maybe we can remove WormMap and WormSet to reduce the HPPC lib?