Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS support for PAC in System Preferences #23

Merged
merged 5 commits into from
Jun 3, 2018

Conversation

LKleinNux
Copy link
Contributor

The PAC File in the macOS System Preferences is available through the pyobjc SystemConfiguration module.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.9%) to 93.542% when pulling 256ef09 on LKleinNux:feature/pac-macos-preferences into 6288121 on carsonyl:master.

@coveralls
Copy link

coveralls commented May 30, 2018

Coverage Status

Coverage decreased (-4.7%) to 91.701% when pulling c7af263 on LKleinNux:feature/pac-macos-preferences into 6288121 on carsonyl:master.

@carsonyl
Copy link
Owner

Thanks so much! I will take a look as soon as I can.

@carsonyl carsonyl merged commit 8e76541 into carsonyl:master Jun 3, 2018
@carsonyl
Copy link
Owner

carsonyl commented Jun 3, 2018

Thanks again for your contribution! Good call on deprecating and replacing from_registry.

I don't normally use a Mac, so I trust these changes work for you. I've released v0.9.0 on PyPI that includes your changes.

@LKleinNux
Copy link
Contributor Author

Thank you for accepting it and releasing it so fast 🙂

@LKleinNux LKleinNux deleted the feature/pac-macos-preferences branch June 4, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants