Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching updated TLD lists is already disabled, so the default TLD list that is included with the library will always be used and there is nothing to cache. Explicitly disabling the cache prevents possible occurrences of john-kurkowski/tldextract#254.
I'm running into john-kurkowski/tldextract#254 when using pypac 0.16.0 on Windows Server 2016.
This is a suggested fix from that issue and makes sense to include in this library because pypac isn't using the dynamic TLD list feature of tldextract so there is nothing to cache.
https://github.com/john-kurkowski/tldextract#note-about-caching
Once we made this change locally pypac worked as I expected.