Make React a peer dependency #268
Conversation
This project fails if the React is not v15+, and you can't have your own version of React because webpack will bundle the one from the project that uses Carte Blanche.
|
I will close this as peerDepedencies are npm2 and we want to move forward. Let's define engine npm3 and only focus on this. see https://codingwithspike.wordpress.com/2016/01/21/dealing-with-the-deprecation-of-peerdependencies-in-npm-3/ |
|
Err, that doesn't actually solve the problem, you still need to declare React 15+ as your peer dependency because Carte Blanche doesn't work with 0.14 and there can only be one React in the project, so the project needs to use React 15+ too… |
|
How would the peer dependency help here especially with npm3? |
|
It would tell the dev that is installing carte-blanche if their version of On Mon, Jun 27, 2016 at 12:11 AM Nik Graf notifications@github.com wrote:
Wout. |
|
@wmertens I'm pretty sure in npm3 you get an invalid dep error as it flattens out them. Is this not correct? |
This project fails if the React is not v15+, and you can't have your own version of React because webpack will bundle the one from the project that uses Carte Blanche.