-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: compile in release mode with debug info by default #250
Conversation
5740018
to
729c8b6
Compare
729c8b6
to
369e244
Compare
c17f4e2
to
ede4fcc
Compare
369e244
to
06fb18a
Compare
ede4fcc
to
3d36632
Compare
f578360
to
6a175f3
Compare
6a175f3
to
8315bce
Compare
8315bce
to
d67773d
Compare
d67773d
to
988d4fd
Compare
Tested the different builds and the flags look good.
Another point, a bit unrelated to this PR is removing the Emscripten documentation from the README.md. A brief comment pointing to the wiki should suffice. Should we do the same for the mingw toolchain? |
I created issue #261 for me to improve README/help later (to not delay release). |
70d0530
to
e6bf24e
Compare
988d4fd
to
0dcb572
Compare
release?=no | ||
sanitize?=no | ||
coverage?=no | ||
|
||
# If not build type is chosen, set the default to release with debug information, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# If not build type is chosen, set the default to release with debug information, | |
# If no build type is chosen, set the default to release with debug information, |
This PR switch the default compilation from release with asserts enabled for everything, to release with debug information with asserts disabled only for
interpret.cpp
. This makes sure people will compile an efficient emulator with justmake
when packaging by default, not requiring the use ofmake relwithdebinfo=yes
ormake release=yes
anymore when packaging.The default make is chosen to contain debug information because some distros may want to strip and move the debug information into a second debug package (for example ArchLinux does this).
Change were mades in CI to always test with debug information, except for tagged releases.
IMPORTANT: After this PR, if you want to compile with asserts for
interpret.cpp
, please compile withmake debug=yes
, this is something only emulator developers care.PR main changes
interpret.cpp
with-DNDEBUG
for release/relwithdebinfo modesrelwithdebinfo=yes
by default, but usedebug=yes
for CI testssha3.c
(third party source) with-O3
to speed up ci-O1
optimizations on sanitize action to make CI fasterlibcartesi.so
symlinks insrc
, to make linkage on external programs dependent on in-development emulator straightforward