Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy api #668

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Copy api #668

merged 2 commits into from
Jun 11, 2024

Conversation

joaopapereira
Copy link
Member

There is a breaking change on the v1.SignatureFetcher I decided to do this so that we do not have another interface to do the same thing. Nevertheless we can create a new Interface and eventually deprecate this one.

Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Still going through but mostly looks pretty good)

pkg/imgpkg/v1/copy.go Show resolved Hide resolved
name: basic
authors:
- name: Carvel Team
email: carvel@vmware.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praveenrewar
Copy link
Member

@joaopapereira I think a rebase will be required to trigger the tests again (without the harbor test).

Signed-off-by: Joao Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
@joaopapereira joaopapereira merged commit c9be069 into carvel-dev:develop Jun 11, 2024
6 checks passed
@joaopapereira joaopapereira deleted the copy-api branch June 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants