-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy api #668
Copy api #668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Still going through but mostly looks pretty good)
name: basic | ||
authors: | ||
- name: Carvel Team | ||
email: carvel@vmware.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: carvel@cncf.com
@joaopapereira I think a rebase will be required to trigger the tests again (without the harbor test). |
Signed-off-by: Joao Pereira <joaod@vmware.com>
Signed-off-by: João Pereira <joaod@vmware.com>
There is a breaking change on the
v1.SignatureFetcher
I decided to do this so that we do not have another interface to do the same thing. Nevertheless we can create a new Interface and eventually deprecate this one.