Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cves v0.49.x #651

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Fix cves v0.49.x #651

merged 6 commits into from
Dec 5, 2022

Conversation

neil-hickey
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?


Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


Signed-off-by: Neil Hickey <nhickey@vmware.com>
@neil-hickey
Copy link
Contributor Author

@rohitagg2020 / @praveenrewar Seems like theres a desire to test on two different version of golang on this line. Do we still want that? And what should the second one be, (one being 1.19.3)?

test-gh-k8s-1.16

Signed-off-by: Neil Hickey <nhickey@vmware.com>
@rohitagg2020
Copy link
Contributor

@neil-hickey Two versions are for K8s. One being latest and the other being k8s 1.16.

Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@100mik 100mik merged commit 6d4885e into v0.49.x Dec 5, 2022
@praveenrewar praveenrewar deleted the nh-fix-cves_v0.49.x branch March 28, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants