Use app label as app change label for long app names #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenrewar
force-pushed
the
app-name-limit
branch
from
59427cd
to
4515439
Compare
If app names have more than 63 character, use the app label as app change label instead of the app name as there is a hard limit on the number of characters that can be present in a label value Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
praveenrewar
force-pushed
the
app-name-limit
branch
from
4515439
to
aaab30c
Compare
cppforlife
reviewed
Jan 26, 2023
| @@ -122,3 +125,10 @@ func (a RecordedAppChanges) Begin(meta ChangeMeta) (*ChangeImpl, error) { | |||
|
|
|||
| return change, nil | |||
| } | |||
|
|
|||
| func (a RecordedAppChanges) changeLabelValue() string { | |||
There was a problem hiding this comment.
anything we are doing to deal with renames of an app? (or is this future work?)
There was a problem hiding this comment.
As of now, we abandon all the app-changes in case of a rename (with user confirmation), so this check should be good for now to resolve the issue. The only difference that will be there now is that we will not be able to list the app-changes with old names. Example:
$ kapp deploy -a very-long-name -f config.yml
$ kapp rename -a very-long-name --new-name short-name
$ kapp app-changes list -a very-long-name
kapp: Error: App 'very-long-name' (namespace: name-limit) does not exist:
The error would happen because of the meta calls.
For future, we can completely migrate to using the label.
cppforlife
reviewed
Jan 26, 2023
|
LGTM |
praveenrewar
changed the title
|
Linked the related issue ^ |
praveenrewar
added a commit
that referenced
this pull request
Feb 1, 2023
If app names have more than 63 character, use the app label as app change label instead of the app name as there is a hard limit on the number of characters that can be present in a label value Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
praveenrewar
added a commit
that referenced
this pull request
Feb 1, 2023
If app names have more than 63 character, use the app label as app change label instead of the app name as there is a hard limit on the number of characters that can be present in a label value Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
praveenrewar
added a commit
that referenced
this pull request
Feb 2, 2023
If app names have more than 63 character, use the app label as app change label instead of the app name as there is a hard limit on the number of characters that can be present in a label value Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
praveenrewar
added a commit
that referenced
this pull request
Feb 2, 2023
If app names have more than 63 character, use the app label as app change label instead of the app name as there is a hard limit on the number of characters that can be present in a label value Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
praveenrewar
added a commit
that referenced
this pull request
Feb 7, 2023
praveenrewar
added a commit
that referenced
this pull request
Feb 7, 2023
praveenrewar
added a commit
that referenced
this pull request
Feb 7, 2023
praveenrewar
added a commit
that referenced
this pull request
Feb 7, 2023
praveenrewar
added a commit
that referenced
this pull request
Feb 7, 2023
praveenrewar
added a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use app label to as app change label for long app names
If app names have more than 63 character, use the app label as app change label instead of the app name as there is a hard limit on the number of characters that can be present in a label value
This is the first step towards fixing #646
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: