Improving performance enhancement specifically during diff stage #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving performance enhancement specifically during diff stage.
By
go profiling
, we have noticed that there are too many calls to deepCopy and AsYAMLBytesImprovements done:
Deepcopy
until the resource being rebased matches with the resource for which rebase resource is defined.default.go
which was already in yaml was unnecessary being converted to struct and then back to yaml. Removed this unnecessary conversion.AsYAMLBytes
.Only one breaking scenario w.r.t. changes proposed:
The chances of this scenario are extremely low…
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: